Skip to content

Port: "Afform - Fix live-update of token-based field defaults" to 6.17 - #36440

Merged
eileenmcnaughton merged 1 commit into
6.17from
port-36439-6.17
Aug 7, 2026
Merged

Port: "Afform - Fix live-update of token-based field defaults" to 6.17#36440
eileenmcnaughton merged 1 commit into
6.17from
port-36439-6.17

Conversation

@civicrm-builder

@civicrm-builder civicrm-builder commented Aug 7, 2026

Copy link
Copy Markdown

Port of #36439 to 6.17.

@colemanw @github-actions
Afform - Fix live-update of token-based field defaults
786687a 
identifyTokens() returns a Set (since 575232f), which has .size not
.length. The guard  was therefore always undefined/falsy,
so the  watcher that recalculates the default whenever a
source field changes was never registered.

Regressed by: 575232f (Afform - fix token replacement if multiple instances of same token)
Fixes dev/core#6674
@civicrm-builder civicrm-builder mentioned this pull request Aug 7, 2026
Merged
@civibot

civibot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
PR commands & links...
  • /rebase <branch-name> will rebase your branch and change the base of the PR.
  • /squash will combine all commits (keeping only the first commit messsage).
  • /port <branch-name> will create a copy of this PR against a different branch.
  • /lintroll will automatically fix linting errors, amending commits as needed.
  • retest this please will rerun the tests and rebuild the demo site.
  • 📖 Review standards
  • 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the 6.17 label Aug 7, 2026
@eileenmcnaughton
eileenmcnaughton merged commit 8f807a9 into 6.17 Aug 7, 2026
1 check passed
@eileenmcnaughton
eileenmcnaughton deleted the port-36439-6.17 branch August 7, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.17 port

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@civicrm-builder @eileenmcnaughton @colemanw